D23712: [Cuttlefish] Overhaul program, use Kirigami

Nathaniel Graham noreply at phabricator.kde.org
Wed Sep 4 17:23:51 BST 2019


ngraham added inline comments.

INLINE COMMENTS

> Tools.qml:30
> +    width: parent.width
> +    RowLayout {
> +        anchors.verticalCenter: parent.verticalCenter

The fake toolbar created here feels too short. I would make it taller by a few pixels so there's more room above and below the controls.

> Tools.qml:37
>          }
> -    }
> -    tools: RowLayout {
> -
> -        spacing: units.gridUnit / 2
> -
> -        PlasmaComponents.TextField {
> +        Kirigami.SearchField {
>              id: filterInput

There's a bunch of unnecessary extra space to the left:

F7318225: Screenshot_20190904_102232.png <https://phabricator.kde.org/F7318225>

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg
Cc: ndavis, filipf, davidedmundson, ngraham, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190904/bebf2893/attachment.html>


More information about the Plasma-devel mailing list