D23714: Manipulate Document prototype for createElement

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Sep 4 09:33:15 BST 2019


broulik created this revision.
broulik added reviewers: Plasma, fvogt, ognarb.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This fixes Shadydom SHIM breaking because we overrode `createElement` and then the metadata it adds go missing, breaking websites.
  
  BUG: 411556

TEST PLAN
  (Sorry, patch directly from suse VM so I could test in Firefox ESR :D)
  
  - Firefox ESR 60 now has working Polymer (tested with Brightspace demo page)
  - Firefox ESR 60 document.createElement("audio") stuff still working well
  - Firefox ESR 60 "new Audio()" audio (e.g. Google Translate) still working well
  
  - Test in newer browsers pending

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23714

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190904/e23439a6/attachment.html>


More information about the Plasma-devel mailing list