D23663: RandR: Replicate outputs with XRender extension

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> xrandrconfig.cpp:336
> +    for (auto *out : m_outputs) {
> +        if (out->applyReplicationSource()) {
> +            KScreen::OutputPtr kscreenOut = kscreenOutputs[out->id()];

this goes against the pattern above where we build up a changeset list and then apply it

Also potentially we call changeOutput twice if it's in the toChange above. We want to avoid that

> xrandrconfig.cpp:658
> +    if (uint(kscreenOutput->replicationSource()) == xOutput->replicationSource()) {
> +        xOutput->updateReplicationSource();
> +        if (!sendConfig()) {

this method returns an important bool that's not checked

> xrandrconfig.cpp:659
> +        xOutput->updateReplicationSource();
> +        if (!sendConfig()) {
> +            return false;

why do we send config twice?

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D23663

To: romangg, #kwin, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190904/1860b111/attachment.html>