D23677: [Folder View] Load icon only for isPopup case

[Eike Hein]

hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.


  Hmm, I'm not a fan. That only the isPopup case ends up showing the icon in the shell is something you and I know from the outside, but I don't think a widget should be making that assumption. Otherwise we bake implementation details of the containents into widget code, and if we ever change the former we have to fix the widgets. Take for example a widget list like the one bandied about for config modes on the sprint.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23677

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190904/abf0c4f0/attachment.html>