D23676: [Folder View] Only install watch on .directory file if actually used

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Sep 2 13:32:48 BST 2019


broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Installing a `KDirWatch` checks file system type to determine which backend to use (e.g. cannot use inotify on NFS), potentially blocking.

TEST PLAN
  - Folder icon was still correctly shown in the panel
  - Changing the folder icon in Dolphin had the panel icon change live
  
  - Cascading folder popups no longer install a dir watch when opening

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23676

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190902/740173f7/attachment.html>


More information about the Plasma-devel mailing list