D24743: Update GTK settings according to Plasma settings

Mikhail Zolotukhin noreply at phabricator.kde.org
Thu Oct 31 18:46:44 GMT 2019


gikari added inline comments.

INLINE COMMENTS

> ervin wrote in configeditor.cpp:49
> Better wrap the const char* in a QStringLiteral.
> 
> Also, but more of a nitpick this time: style wise I'd favor using = for those initialization (and others in the file) than parenthesis. It gets too close the most vexing parse territory, I'd rather not potentially expose a future developer touching that file to it.

Where generally should I use equals sign (`=`), where parenthesis (`()`) and where braces (`{}`) for initialization? I didn't find any note about that in coding style <https://community.kde.org/Policies/Frameworks_Coding_Style>.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24743

To: gikari, #plasma, #vdg
Cc: ervin, ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191031/85ed1f3e/attachment.html>


More information about the Plasma-devel mailing list