D25090: kcm/fonts: Do not load image preview before loading settings

Bhushan Shah noreply at phabricator.kde.org
Thu Oct 31 12:33:58 GMT 2019


bshah created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.

REVISION SUMMARY
  The way image preview works is it tries to actually "set" and then
  "reset" the original value to render the text.
  
  However if we don't have default or user set settings loaded, it will
  reset it back to "NotSet" in end instead of user set value and this is
  not what we want.

TEST PLAN
  this alone is not enough to make kcm save subpixel properly
  but this is part of patch series

REPOSITORY
  R119 Plasma Desktop

BRANCH
  bshah/fonts

REVISION DETAIL
  https://phabricator.kde.org/D25090

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: bshah
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191031/d18cb4ef/attachment-0001.html>


More information about the Plasma-devel mailing list