D24847: KCM Icons fix theme selected when we hit delete theme

Kevin Ottens noreply at phabricator.kde.org
Wed Oct 30 12:09:08 GMT 2019


ervin added a comment.


  nitpick, but otherwise LGTM, giving time to others (in particular Nate) to chip in.

INLINE COMMENTS

> iconsmodel.cpp:87
>              }
> -
>              emit pendingDeletionsChanged();

I'd say keep the empty line please.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24847

To: bport, mart, ervin, #plasma, crossi
Cc: bport, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191030/ed0431e1/attachment.html>


More information about the Plasma-devel mailing list