D25055: [containments/desktop] Delete the "Tweaks" page and its options
Nathaniel Graham
noreply at phabricator.kde.org
Tue Oct 29 18:42:47 GMT 2019
ngraham created this revision.
ngraham added reviewers: mart, GB_2, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
With the new global edit mode, both of the options on the Tweaks page become unnecessary:
- The option to hide the toolbox becomes dangerous because it breaks global edit mode
- The option to toggle press-and-hold does nothing because we always use press-and-hold
TEST PLAN
- Right-click desktop > Configure Desktop > No "Tweaks" page at the bottom of the list: F7687032: No Tweaks.png <https://phabricator.kde.org/F7687032>
- Widget moving, resizing, and editing behaviors in side and out of edit mode are unchanged
- You can no longer turn off the toolbox and break edit mode
- You can no longer uselessly toggle the press-and-hold checkbox that has no effect
REPOSITORY
R119 Plasma Desktop
BRANCH
delete-tweaks-page (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25055
AFFECTED FILES
containments/desktop/package/contents/config/config.qml
containments/desktop/package/contents/config/main.xml
containments/desktop/package/contents/ui/ConfigTweaks.qml
containments/desktop/package/contents/ui/main.qml
To: ngraham, mart, GB_2, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191029/97fbb876/attachment.html>
More information about the Plasma-devel
mailing list