D25045: kimpanel: don't crash when ibus is already loaded

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  No need to replace the current engine if we already have an acceptable one set.
  
  Otherwise it confuses Qt and it asserts in Qt.
   7  0x00007f517fcdf8e6 in qt_assert (assertion=assertion at entry=0x7f5179fee560 "engine_name == desc.engine_name", file=file at entry=0x7f5179fee318 "/home/apol/devel/frameworks/qt5/qtbase/src/plugins/platforminputcontexts/ibus/qibusplatforminputcontext.cpp",
  
    line=line at entry=583) at ../../include/QtCore/../../../../../devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.h:90
  
  8  0x00007f5179fdb6f4 in QIBusPlatformInputContext::globalEngineChanged (this=0x55831b2c7ff0, engine_name=...) at ../../../../include/QtCore/../../../../../devel/frameworks/qt5/qtbase/src/corelib/tools/qarraydata.h:236
   9  0x00007f5179fe7f6d in QIBusPlatformInputContext::qt_static_metacall (_o=<optimized out>, _c=<optimized out>, _id=<optimized out>, _a=<optimized out>) at .moc/moc_qibusplatforminputcontext.cpp:147

TEST PLAN
  Now I can start the plasmoid without it crashing.
  I'm guessing users so far were running against a release build of Qt without asserts.
  Starting ibus with the session now works as well, in contrast to having to start it explicitly

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D25045

AFFECTED FILES
  applets/kimpanel/backend/ibus/ibus15/panel.cpp

To: apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191029/4ba59226/attachment.html>