D25006: Checking dpi value being empty is not enought

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> advancedconfig.cpp:193
>  
>      if (!dpiValue.isEmpty()) {
> +       // minimal possible valid step from Force font DPI setings

You can combine both of these conditions into the same if statement.

> advancedconfig.cpp:195
> +       // minimal possible valid step from Force font DPI setings
> +       if (dpiValue >= QStringLiteral("24")) {
> +           args[QStringLiteral("kde_settings.conf/X11/ServerArguments")] = dpiArgument;

`>=` has a different meaning when comparing strings vs comparing integers. You need to first parse or cast `dpiValue` to an `int`, then compare it to the number 24.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D25006

To: gcraciunescu, filipf, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191028/4efa2d74/attachment.html>