D24953: [applets/weather] Use unit description from KUnitConversion
Ismael Asensio
noreply at phabricator.kde.org
Sat Oct 26 00:36:49 BST 2019
iasensio created this revision.
iasensio added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
iasensio requested review of this revision.
REVISION SUMMARY
Use unit description directly from KUnitConversion instead of making a new string.
This avoids duplicating translation strings and improves consistency.
The units name is now `description` (`symbol`) also for consistency with krunner
TEST PLAN
No behavior changes within the applet
`Configure` -> `Units` shows translated `description` (`symbol`) for every unit
REPOSITORY
R114 Plasma Addons
BRANCH
weather_use_unit_description
REVISION DETAIL
https://phabricator.kde.org/D24953
AFFECTED FILES
applets/weather/plugin/abstractunitlistmodel.h
applets/weather/plugin/plugin.cpp
applets/weather/plugin/util.cpp
applets/weather/plugin/util.h
To: iasensio, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191025/53ecd609/attachment.html>
More information about the Plasma-devel
mailing list