D24919: Don't reset model when device state changes

Jan Grulich noreply at phabricator.kde.org
Thu Oct 24 16:28:13 BST 2019


jgrulich requested changes to this revision.
jgrulich added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> networkmodel.cpp:829
>          item->invalidateDetails();
> +        int row = m_list.indexOf(item);
> +        Q_EMIT dataChanged(index(row, 0), index(row, 0), item->changedRoles());

Please, see the comment in one of the other PRs. You can just use updateItem(item) and it will do everything for you. Sorry for not checking that earlier.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D24919

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191024/813c2ed3/attachment.html>


More information about the Plasma-devel mailing list