D24924: Don't reset model when adding an active connection
Jan Grulich
noreply at phabricator.kde.org
Thu Oct 24 16:08:16 BST 2019
jgrulich requested changes to this revision.
jgrulich added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> networkmodel.cpp:313
> + int row = m_list.indexOf(item);
> + Q_EMIT dataChanged(index(row, 0), index(row, 0));
> }
Shouldn't you add item->changedRoles() as the last parameter?
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D24924
To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191024/e01088ea/attachment.html>
More information about the Plasma-devel
mailing list