D24919: Don't reset model when device state changes

Jan Grulich noreply at phabricator.kde.org
Thu Oct 24 16:07:57 BST 2019


jgrulich accepted this revision.
jgrulich added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> networkmodel.cpp:830
> +        int row = m_list.indexOf(item);
> +        Q_EMIT dataChanged(index(row, 0), index(row, 0));
>  //             qCDebug(PLASMA_NM) << "Item " << item->name() << ": device state changed to " << item->deviceState();

Shouldn't you add item->changedRoles() as the last parameter?

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  noreset2

REVISION DETAIL
  https://phabricator.kde.org/D24919

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191024/11ae0a07/attachment.html>


More information about the Plasma-devel mailing list