D24903: Don't reset model when activeconnectionstate changed

Nicolas Fella noreply at phabricator.kde.org
Wed Oct 23 22:33:18 BST 2019


nicolasfella created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
nicolasfella requested review of this revision.

REVISION SUMMARY
  resetting the model when a single property changes is using a sledgehammer to crack a nut. emitting dataChanged for the affected row is enough.

TEST PLAN
  (de)activated connections in plasmoid and mobile wifi KCM. 
  Verified with hotspot that lots of calls to modelReset disappeared

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  activeconn

REVISION DETAIL
  https://phabricator.kde.org/D24903

AFFECTED FILES
  libs/models/networkmodel.cpp

To: nicolasfella, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191023/2696696d/attachment.html>


More information about the Plasma-devel mailing list