D24879: [ComboBox] Follow focusPolicy

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Oct 23 08:20:14 BST 2019


broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Since we have a `MouseArea` in our `contentItem` stealing events from the underlying `Control`, its `focusPolicy` (defaults to `Qt.StrongFocus` for `ComboBox`) is never followed.
  This causes the `ComboBox` not to get focused when clicking it, making it impossible to use the arrow keys to navigate it.

TEST PLAN
  - It now behaves like a widget `QComboBox`. Clicked it, could use arrow keys to navigate the popup
  - Is highlighted blue with focus like a widget `QComboBox` afterwards

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24879

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191023/f03d2fb6/attachment.html>


More information about the Plasma-devel mailing list