D24877: RFC: Move shortcuts out of ksmserver into kglobalaccel

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  I want to move the shortcuts out of ksmserver. None of the actions now involve ksmserver directly and the
  layering is now such that a wayland only session could run without ksmserver.
  
  This patch uses .desktop file actions so kglobalaccel just calls the relevant hook directly rather than needing
  a background service constantly running
  
  WIP as:
  I need migration,
  I need to write the default shortcut in the correct syntax.
  We would need some way to hide the default _launch entry
  We've lost the kauthorized key, but we should be handling that in the receiver anyway?
  Deal with a certain distro renaming qdbus.
  
  But I wanted some early feedback on whether this was a clever use of the existing framework, or a dirty hack.

TEST PLAN
  WIP

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24877

AFFECTED FILES
  ksmserver/main.cpp
  ksmserver/server.cpp
  ksmserver/server.h
  startkde/plasma-session/CMakeLists.txt
  startkde/plasma-session/org.kde.plasma.session.desktop

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191022/1e655526/attachment.html>