D24847: KCM Icons fix theme selected when we hit delete theme

[Nathaniel Graham]

ngraham added a comment.


  Does this patch have unmarked dependencies? It doesn't apply for me:
  
    $ arc patch D24847
    INFO  Base commit is not in local repository; trying to fetch.
    created and checked out branch arcpatch-D24847.
    
    
        This diff is against commit 38806dbe3f9a65aea6ae031b959ff4adac9bf444, but
        the commit is nowhere in the working copy. Try to apply it against the
        current working copy state? (528388bfeb69fc22a259845e28fbef2a375e7bd6)
        [Y/n] y
    
    Checking patch kcms/icons/package/contents/ui/main.qml...
    Checking patch kcms/icons/main.cpp...
    error: while searching for:
        m_model->load();
        m_model->setSelectedTheme(KIconTheme::current());
        updateNeedsSave();
    }
    
    void IconModule::save()
    
    error: patch failed: kcms/icons/main.cpp:148
    Checking patch kcms/icons/iconsmodel.cpp...
    Applied patch kcms/icons/package/contents/ui/main.qml cleanly.
    Applying patch kcms/icons/main.cpp with 1 reject...
    Rejected hunk #1.
    Applied patch kcms/icons/iconsmodel.cpp cleanly.
    
     Patch Failed! 
    Usage Exception: Unable to apply patch!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24847

To: bport, mart, ervin, #plasma, crossi
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191022/219a9ccd/attachment-0001.html>