D24853: [DigitalClock] Fix layout and QML warnings

[Konrad Materka]

kmaterka marked 3 inline comments as done.
kmaterka added inline comments.

INLINE COMMENTS

> davidedmundson wrote in configTimeZones.qml:32
> Do you need these?
> 
> Generally it's a sign of a problem or bad layering if the root item has anchors in it.

Ops, copy&pPaste from HolidayConfig.qml. I'll remove it, width/height are not needed, I just checked, AppletConfiguration.qml handles that.

> davidedmundson wrote in configTimeZones.qml:56
> If we're going to port stuff, we may as well port to:
> 
> https://api.kde.org/frameworks/kirigami/html/classorg_1_1kde_1_1kirigami_1_1InlineMessage.html
> 
> the library version of this

Cool! I need there must be something!

> davidedmundson wrote in configTimeZones.qml:96
> What's this for? Opacity should be inherited by children

I will use Kirigami component.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24853

To: kmaterka, #plasma, #plasma_workspaces
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191022/60c4070e/attachment-0001.html>