D24849: [Windows Runner] Gather window again when running result

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Since we fixed `RunnerManager::teardown` to actually be emitted, the runner would throw away its gathered window info and then crash in `run()`.
  I couldn't figure out what the proper API was so this is a workaround to keep it from crashing at least.
  However, the runner also didn't check whether the window was actually still valid by the time `run()` was called, so querying for the window again once it is called and checking validity is a good thing either way imho.
  In the future, this probably should be ported to using libtaskmanager :)
  
  BUG: 412386
  FIXED-IN: 5.17.1

TEST PLAN
  - Can activate windows fine again without crashing

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24849

AFFECTED FILES
  runners/windows/windowsrunner.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191022/f448e46b/attachment-0001.html>