D24844: [Applet] Remove "Raise Maximum Volume" menu item from Hamburger menu

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This action suffers from the following problems:
  
  - It's buggy: tt does not take into account whether or not the maximum volume has already been raised globally using the settings window, and if it has and you toggle it, the slider's position gets stuck in an incorrect state
  - It's unnecessary: there is already a more reliable and useful way to raise the maximum volume level in the settings window
  - It't one of the last two items in the hamburger menu that user feedback indicates nobody clicks on, and we want to move in the direction of removing it

TEST PLAN
  The hamburger menu no longer lists a "Raise Maximum Volume" menu item
  
  You can still raise the baximum volume by clicking on the configure button in the applet to show the settings window

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  single-way-to-raise-max-volume (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24844

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191021/136ed621/attachment-0001.html>