D24838: [KCMs/Night Color] Add a valueForText handler for the new SpinBox
Vlad Zahorodnii
noreply at phabricator.kde.org
Mon Oct 21 20:56:10 BST 2019
zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.
Uh, I don't use Ukrainian locale. However, it doesn't matter that much. We format numbers practically the same way as in en_US.
Given the current implementation of textFromValue and the fact that the maximum value of transTimeField is capped, this change is good to go. However, it would be great to respect the user's locale.
REPOSITORY
R119 Plasma Desktop
BRANCH
valuefromtext (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D24838
To: ngraham, #plasma, zzag
Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191021/5ddfe349/attachment.html>
More information about the Plasma-devel
mailing list