D24813: [KCM/Night Color] Use a spinbox with an appropriate suffix for the duration

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.qml:290
>                                  Kirigami.FormData.label: i18n("Transition duration:")
> -                                backend: cA.transitionTimeStaged
> -                                onBackendChanged: {cA.transitionTimeStaged = backend;

where has this gone?

> main.qml:301
> +                                textFromValue: function(value, locale) {
> +                                    return i18n("%1 minutes", value)
> +                                }

i18np

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24813

To: ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191021/ce78f60c/attachment-0001.html>