D24766: Revert change to make the notification persistent
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Fri Oct 18 21:57:12 BST 2019
apol added a comment.
Other than that, LGTM
INLINE COMMENTS
> DiscoverNotifier.cpp:67
> KRun::runCommand(QStringLiteral("plasma-discover"), nullptr);
> - if (m_updatesAvailableNotification) { m_updatesAvailableNotification->close(); }
> }
I wouldn't remove these. It's good that it reacts to opening Discover. It shows that it's connected.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D24766
To: ngraham, apol, broulik, #discover_software_store
Cc: ognarb, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191018/e615d37f/attachment-0001.html>
More information about the Plasma-devel
mailing list