D24743: Update GTK settings according to Plasma settings
Mikhail Zolotukhin
noreply at phabricator.kde.org
Fri Oct 18 18:08:02 BST 2019
gikari added inline comments.
INLINE COMMENTS
> broulik wrote in gtkconfig.cpp:116
> In what way? There's a comment in the style KCM saying
>
> // ##### FIXME - Doesn't apply all settings correctly due to bugs in KApplication/KToolbar
> KGlobalSettings::self()->emitChange(KGlobalSettings::ToolbarStyleChanged);
@broulik signal from `KGlobalSettings` is never recieved with `KGlobalSettings::ToolbarStyleChanged` value as an argument. I debuged style kcm and daemon simultaneously and after stepping over the above line and the previous one which is
KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, KGlobalSettings::SETTINGS_STYLE);
Only signal with `SettingsChanged` is received within the daemon.
REPOSITORY
R99 KDE Gtk Configuration Tool
REVISION DETAIL
https://phabricator.kde.org/D24743
To: gikari, #plasma, #vdg
Cc: ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191018/4243ac2a/attachment.html>
More information about the Plasma-devel
mailing list