D24265: support global edit mode

[David Edmundson]

davidedmundson added a comment.


  Can you explain the intended difference between top and topcenter?

INLINE COMMENTS

> ToolBoxButton.qml:87
>          id: stateTimer
> -        interval: 100
> +        interval: 0//toolBoxButton.state.indexOf("center") != -1 ? 0 : 100
>          onTriggered: updateState()

fix

> ToolBoxRoot.qml:42
>      }
> -
> -    //FIXME: this timer shouldn't exist, but unfortunately when the focus passes
> -    //from the desktop to the dialog or vice versa, the event is not atomic
> -    //and ends up with neither of those having focus, hiding the dialog when
> -    //it shouldn't
> -    Timer {
> -        id: hideDialogTimer
> -        interval: 0
> -        //NOTE: it's checking activeFocusItem instead of active as active doesn't correctly signal its change
> -        property bool desktopOrDialogFocus: main.Window.activeFocusItem !== null || (toolBoxLoader.item && toolBoxLoader.item.activeFocusItem !== null)
> -        onDesktopOrDialogFocusChanged: {
> -            if (!desktopOrDialogFocus) {
> -                hideDialogTimer.restart();
> -            }
> -                
> -        }
> -        onTriggered: {
> -            if (!desktopOrDialogFocus) {
> -                open = false;
> -            }
> -        }
> -    }
> -
> +/*
>      signal minimumWidthChanged

fix

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mart/editMode

REVISION DETAIL
  https://phabricator.kde.org/D24265

To: mart, #plasma, ngraham
Cc: davidedmundson, ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191018/f8a954aa/attachment-0001.html>