D24720: [applets/systemtray] Rewrite popups with layouts

Filip Fila noreply at phabricator.kde.org
Thu Oct 17 21:05:58 BST 2019


filipf added a comment.


  In D24720#549292 <https://phabricator.kde.org/D24720#549292>, @ngraham wrote:
  
  > Nice, this feels indistinguishible from the current one, which is a good sign. I see what you mean about the Headings in RTL. Does the Kirigami version work properly? If so, I wonder if it might be worth it to just use that instead given that the future of PlasmaComponents is on shaky ground (T11558: kill plasma components in favour of QtQuickControls2 + kirigami <https://phabricator.kde.org/T11558>)
  
  
  It was unfortunately all the same as with Plasma imports.
  
  By adding checks for orientation and using a spacer in the headings row layout I was able to get RTL working right though.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24720

To: filipf, #plasma, #vdg
Cc: ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191017/a322786b/attachment.html>


More information about the Plasma-devel mailing list