D24743: Update GTK settings according to Plasma settings

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  To increase usability,
  
  - fonts
  - icon theme
  - cursor theme
  - toolbar style (icons-only, text below buttons etc)
  - icons visibility in menus
  - icons visibility on buttons
  
  settings for gtk applications are now set in respective kcms, instead of separate gtk kcm.
  
  Various kcms are sending signals (dbus or Qt ones) about the configuration change. Then the gtkconfig kded daemon connects to these signals and changes gtk config files to match new settings, that were set in those kcms.
  
  D24701 <https://phabricator.kde.org/D24701> is needed to notify about cursor change on Wayland.
  
  Live reloading (on a fly) is not going to work for some settings on X11. This applies to cursor theme, it's changed by partially. To illustrate that open Nautilus File Manager, change cursor theme and try to double click folders. You will see, that "loading" cursor changed its theme, but "idle" one did not.
  
  What is not tested:
  
  - Toolbar style for gtk3 apps other that Geany (absence of live reloading may be a Geany bug)
  - Toolbar style and icons visibility on Wayland
  
  Depends on D24701 <https://phabricator.kde.org/D24701>
  
  BUG: 401507
  BUG: 401507

TEST PLAN
  1. To test gtk3 applications live reloading on X11, install xsettingsd.
  2. Restart kded5.
  3. Open gtk2 app, gtk3 app
  4. Change above mentioned settings in respective KCMs
  5. Check if gtk applications are changing their settings before (sometimes) and after their restart.
  
  Rare cases:
  
  - To test icons on buttons use Inkscape about window.
  - To test toolbar style use Geany (gtk3, live reloading does not work) and BleachBit (gtk2)

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  gtk-settings-in-respective-kcms

REVISION DETAIL
  https://phabricator.kde.org/D24743

AFFECTED FILES
  CMakeLists.txt
  kded-module/CMakeLists.txt
  kded-module/configeditor.cpp
  kded-module/configeditor.h
  kded-module/configvalueprovider.cpp
  kded-module/configvalueprovider.h
  kded-module/gtkconfig.cpp
  kded-module/gtkconfig.h
  kded-module/gtkconfig.json

To: gikari
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191017/c786aaa7/attachment.html>