D24732: Rewrite AppChooser dialog
Nathaniel Graham
noreply at phabricator.kde.org
Thu Oct 17 18:20:37 BST 2019
ngraham added a comment.
Give the scrollview a frame and a white background or else apps look cut off and weird and there's a mysteriously hovering scroller: F7616694: Screenshot_20191017_111833.png <https://phabricator.kde.org/F7616694>
Also why are there duplicates in here?
Finally, I would consider adding the "Other applications are available in Discover" text to the bottom, so it doesn't interrupt the dialog's flow.
INLINE COMMENTS
> AppChooserDialog.qml:122
> +
> + MouseArea {
> + id: mouseArea
Change the cursor to the pointing hand cursor when hovering over something that will immediately perform an action when clicked
> AppChooserDialog.qml:140
> +
> + Label {
> + anchors {
Allow this label to become a multi-line string for apps that have long-ish names:
F7616689: Screenshot_20191017_111655.png <https://phabricator.kde.org/F7616689>
REPOSITORY
R838 Flatpak Support: KDE Portal for XDG Desktop
REVISION DETAIL
https://phabricator.kde.org/D24732
To: jgrulich, #plasma
Cc: GB_2, ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191017/98e8ba96/attachment.html>
More information about the Plasma-devel
mailing list