D24683: [KWindowSystem] in icon() return realistic icon size

Méven Car noreply at phabricator.kde.org
Thu Oct 17 16:14:00 BST 2019


meven marked 5 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in windowsystem.cpp:173
> That's adjustment, 16, 32, 48, 64, 128, 256 are standard icon sizes, when you got a value between 2 sizes you adjust it by lower bound. Say (256 - 128) / 2 = 64, so 128 + 64 = 192, when request is smaller than 192 and bigger than 96 (which is same calculated for previous values) it returns 128. If you want write an algorithm for that.

Thank you @anthonyfieroni for the explanation
So in fact the comment stated already this simply:

> take the nearest value for best results

I don't think more comment is necessary.

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24683

To: meven, #kwin, davidedmundson
Cc: anthonyfieroni, mart, zzag, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191017/b213ff71/attachment.html>


More information about the Plasma-devel mailing list