D24691: Add support for WPA3

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> wifisecurity.cpp:403
>  {
> -    if (index == 0) {
> +    if (index == 0) { // None
>          m_ui->stackedWidget->setCurrentIndex(0);

It would be nice to convert use SecurityTypeIndex enum instead of hardcoded values.
It seems to me those values match.

And then change WifiSecurity::securityChanged(int) to WifiSecurity::securityChanged(SecurityTypeIndex) if possible.

> wifisecurity.cpp:415
> +        m_ui->stackedWidget->setCurrentIndex(5);
> +    } else if (index == 7) { // WPA3 Personal
> +        m_ui->stackedWidget->setCurrentIndex(4);

With an enum this could be merged easily with the WPA/WPA2 Enterprise index == 5 case.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D24691

To: jgrulich, #plasma
Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191017/bc707db6/attachment-0001.html>