D24706: Don't use focus color on checkable button backgrounds

[Noah Davis]

ndavis added a subscriber: ngraham.
ndavis added a comment.


  In D24706#548392 <https://phabricator.kde.org/D24706#548392>, @ngraham wrote:
  
  > I see what you're trying to do here, and I approve. But I think it might make more sense to more generally rethink how we indicate focus for buttons. IMO we should draw a highlight around the edges rather than changing the background color, for the following reasons:
  >
  > - It would avoid any confusion whatsoever regarding checkable buttons
  > - It would make the currently focused button stop inappropriately looking like it's a dialog's default button
  > - It would be more consistent with how focus is indicated for other UI elements in Breeze (e.g toolbuttons and line edits)
  > - It would be more consistent with how other focus is indicated for other widget styles and platforms (e.g. macOS, Windows, and GNOME's Adwaita all show focus with a line around the edges)
  
  
  We already do that, it would just be a matter of removing the logic for using the focus color in the background. Here I did that to the focus color and the hover color: F7609151: Screenshot_20191016_153517.png <https://phabricator.kde.org/F7609151>

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191016/e56b0850/attachment.html>