D24683: [KWindowSystem] in icon() return realistic icon size

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> meven wrote in windowsystem.cpp:173
> It was copied from kwindowsystem/src/platforms/xcb/kwindowsytem.cpp
> So I don't know precisely but at least it is coherent with X.
> Unfortunately the commit history does not tell much.

I can't explain the current logic.

@mart  Do you think I should change the logic to give it more sense ?

Perhaps make the 24, 40.. values match the iconWidth i.e :

  if (width <= 16){
  iconWidth = 16;
  else if (width <= 32)
  iconWidth = 32
  else if (width <= 48){
  iconWidth = 48
  ...

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24683

To: meven, #kwin, davidedmundson
Cc: mart, zzag, ngraham, plasma-devel, crossi, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191016/2640c3cc/attachment.html>