D24653: discover: check package status before trying to install/update it

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Oct 15 11:39:13 BST 2019


apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Please submit to master.

INLINE COMMENTS

> PackageKitBackend.cpp:586
>  
> +    if ((info == PackageKit::Transaction::InfoRemoving) || (info == PackageKit::Transaction::InfoObsoleting)) {
> +        // Don't try updating packages which need to be removed

Could you drop the unnecessary parenthesis?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24653

To: alnikiforov, jriddell, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191015/bd6bde90/attachment-0001.html>


More information about the Plasma-devel mailing list