D24519: Delegate KCM cursor theme config management to KConfigXT

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcmcursortheme.cpp:157
>  {
> -    return m_selectedThemeRow;
> -}
> -
> -void CursorThemeConfig::setSelectedSizeRow(int row)
> -{
> -    Q_ASSERT (row < m_sizesModel->rowCount() && row >= 0);
> -
> -    // we don't return early if m_selectedSizeRow == row as this is called after the model is changed
> -    m_selectedSizeRow = row;
> -    emit selectedSizeRowChanged();
> -
> -    int size = m_sizesModel->item(row)->data().toInt();
> -
>      m_preferredSize = size;
>  }

Once you got the NOTIFY part of the property it'll be emitted from here.

> kcmcursortheme.h:50
>      Q_PROPERTY(bool downloadingFile READ downloadingFile NOTIFY downloadingFileChanged)
> +    Q_PROPERTY(int preferredSize READ preferredSize WRITE setPreferredSize)
>  

Should also have the NOTIFY part.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24519

To: bport, #plasma, mart, ervin
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191015/b9ac5456/attachment-0001.html>