D24517: Port kcm cursor to KConfigXT
Kevin Ottens
noreply at phabricator.kde.org
Tue Oct 15 09:49:04 BST 2019
ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.
Just a last nitpick.
INLINE COMMENTS
> CMakeLists.txt:24
> +kconfig_add_kcfg_files(kcm_cursortheme_PART_SRCS cursorthemesettings.kcfgc GENERATE_MOC)
> +install(FILES cursorthemesettings.kcfg DESTINATION ${KDE_INSTALL_KCFGDIR})
> add_library(kcm_cursortheme MODULE ${kcm_cursortheme_PART_SRCS})
Could that be moved in the install file section of the file? Everything related to file installs (but not target installs...) seems to be at the end of that file.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D24517
To: bport, #plasma, mart, ervin, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191015/f59045c2/attachment.html>
More information about the Plasma-devel
mailing list