D24529: [XembedSNIProxy] Check size in each update()

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: davidedmundson, Plasma, Plasma: Workspaces.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  If needed, perform resize in each update().
  Client window may be too big, it must be resized to a certain reasonable size. Sometimes resizing in the constructor is not enough because it is too early and the client window is not fully initialized. Even if client window is resized, on first update it reverts back to original size (or just ignores the first request - some kind of a race condition).
  
  In addition, I applied some rules from: https://community.kde.org/Policies/Kdelibs_Coding_Style
  
  BUG: 358240

TEST PLAN
  I tested it using keepass2, now it shows better results (still not perfect). Window is resized to 32x32, but icon is only 24x24 it top-left. Better than 273x273 with tiny dot in the corner. This is a workaround for unsolvable bug in Mono - AFAIK Windows Forms are not longer maintained so it won't be fixed.
  
  I tested this change with several other apps for regressions, no issues:
  pidgin
  liferea
  hexchat
  tuxguitar
  xchat
  keepassx
  stardict
  and other I don't remember now. No regressions.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24529

AFFECTED FILES
  xembed-sni-proxy/main.cpp
  xembed-sni-proxy/sniproxy.cpp
  xembed-sni-proxy/sniproxy.h

To: kmaterka, davidedmundson, #plasma, #plasma_workspaces
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191010/b2f54390/attachment-0001.html>