D24517: Port kcm cursor to KConfigXT

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> davidedmundson wrote in CMakeLists.txt:22
> Can you also  add
> 
>   install(FILES kded/touchpaddaemon.kcfg
>           DESTINATION ${KDE_INSTALL_KCFGDIR})
> 
> This doesn't explicitly do anything useful, but it allows future metadata extraction for documentation purposes.

Interestingly you didn't request that on my desktoptheme work.

> cursorthemesettings.kcfg:9
> +  <include>QX11Info</include>
> +  <include>X11/Xcursor/Xcursor.h</include>
> +  <group name="Mouse">

Why those includes? They seem unused now since you're not having code in defaults.

> davidedmundson wrote in kcmcursortheme.cpp:72
> I assume Kevin's patch set fixes this?

Yes, giving a bit more time to people to review the latest revisions of my KConfig patches. They changed quite a bit and I didn't get further comment yet.

> kcmcursortheme.h:127
>      QPersistentModelIndex m_appliedIndex;
> -
>  /** Holds the last size that was chosen by the user. Example: The user chooses

Why the empty line removal? The previous line is now stuck with the comment.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24517

To: bport, #plasma, mart, ervin, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191009/860a8498/attachment.html>