D24498: Properly check enabled state of Action for ActionToolBar buttons

Arjen Hiemstra noreply at phabricator.kde.org
Wed Oct 9 12:40:13 BST 2019


ahiemstra marked an inline comment as done.
ahiemstra added inline comments.

INLINE COMMENTS

> apol wrote in ActionToolBar.qml:126
> I'd do the enabled && opacity, it feels very wrong using a real number as a boolean >.<.

Agreed. I made the opacity check more explicit.

REPOSITORY
  R169 Kirigami

BRANCH
  actiontoolbar_enable

REVISION DETAIL
  https://phabricator.kde.org/D24498

To: ahiemstra, #kirigami, ngraham
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191009/05166bc0/attachment.html>


More information about the Plasma-devel mailing list