D24498: Properly check enabled state of Action for ActionToolBar buttons

Arjen Hiemstra noreply at phabricator.kde.org
Tue Oct 8 14:46:09 BST 2019


ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  The opacity binding overrides PrivateActionToolButton's enabled binding,
  which means an Action's enabled property does not get checked for
  ActionToolBar buttons.

TEST PLAN
  With kirigami2gallery, on the Misc Widgets page, change the enabled property
  of one of the actions in the toolbar. Observe that the tool button now gets
  disabled correctly.

REPOSITORY
  R169 Kirigami

BRANCH
  actiontoolbar_enable

REVISION DETAIL
  https://phabricator.kde.org/D24498

AFFECTED FILES
  src/controls/ActionToolBar.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191008/a71fb2bb/attachment.html>


More information about the Plasma-devel mailing list