D24469: Allow the global drawer to become a menu if desired

Marco Martin noreply at phabricator.kde.org
Tue Oct 8 14:28:50 BST 2019


mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  conceptually i like it.
  I would like positioning the menu  right under the button and having the button looking pressed as long as the menu is open (like the ... button does)

INLINE COMMENTS

> GlobalDrawer.qml:221
> +     * When true the global drawer becomes a menu on the desktop. Defauls to false.
> +     */
> +    property bool isMenu: false

@since 2.11

> PageRowGlobalToolBarUI.qml:72
> +            Controls.Menu {
> +                id: menu
> +                contentData: applicationWindow().globalDrawer.actions

x: 0
y: menuButton.height  ?

REPOSITORY
  R169 Kirigami

BRANCH
  toolbarmenu

REVISION DETAIL
  https://phabricator.kde.org/D24469

To: nicolasfella, #vdg, mart
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191008/a842bcb1/attachment.html>


More information about the Plasma-devel mailing list