D24471: [KRDB] Remove Oxygen-era colour exporting code

Carson Black noreply at phabricator.kde.org
Tue Oct 8 14:24:30 BST 2019


cblack added a comment.


  In D24471#543487 <https://phabricator.kde.org/D24471#543487>, @broulik wrote:
  
  > > it seems to have defaulted to always on
  >
  > Yes, I did that because it makes sense.
  >
  > > (which is pretty rare)
  >
  > So, you're saying GTK2 themes are likely to follow color schemes but GTK3 are not?
  
  
  I meant that it was rare for GTK2 themes in 2019 to attempt to follow the colorscheme, not that it was rare for them to not follow the colorscheme.
  
  > 
  > 
  >> (including Breeze GTK) primarily use pixmaps
  > 
  > Basically, we cannot have GTK 2 apps follow color schemes anymore, or did that ever really work?
  
  Well, some GTK2 themes (i.e. oxygen) attempt to follow the colorscheme, but the graphical artifacts caused in other GTK2 themes make it a poor choice to always export colours.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  krdb-remove-oxygen-era-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24471

To: cblack, #plasma, ngraham
Cc: broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191008/2c7655ef/attachment.html>


More information about the Plasma-devel mailing list