D24479: [KCM] Make multi-screen draggability more obvious

David Edmundson noreply at phabricator.kde.org
Tue Oct 8 10:03:21 BST 2019


davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in Output.qml:273
> This is against the laws of Physics.
> I suspect it just erroring out (possibly `rowCount` requiring a `QModelIndex` argument) and just always staying visible. Or the KCM re-creating the `outputModel` which would be weird.

> Or the KCM re-creating the outputModel which would be weird.

It would, but:

  connect (m_config.get(), &ConfigHandler::outputModelChanged,
           this, &KCMKScreen::outputModelChanged);

which gets emitted in

  ConfigHandler::setConfig(KScreen::ConfigPtr config)  

A new screen would be a new config.

I think output model is the same object, but it would retrigger this evaluation.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24479

To: ngraham, romangg, #plasma, #vdg
Cc: davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191008/9c72b271/attachment.html>


More information about the Plasma-devel mailing list