D24470: feedback kcm: Use a horizontal slider like GammaRay does

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> main.qml:80
> +                    var found = false;
> +                    for(var v in modeOptions) {
> +                        if (modeOptions[v] === kcm.plasmaFeedbackLevel) {

Use `Array.findIndex`

> main.qml:91
>  
> -                onActivated: {
> -                    kcm.plasmaFeedbackLevel = modeOptions.get(index).value;
> +                onValueChanged: {
> +                    kcm.plasmaFeedbackLevel = modeOptions[value]

Use `onMoved` which is the slider equivalent to `onActivated`

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24470

To: apol, #plasma, ngraham
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191007/e39a9e82/attachment-0001.html>