D24454: Include an emoji picker

[David Edmundson]

davidedmundson added a comment.


  There's coding style issues, as it's new code you can hopefully just run clang-format over it.

INLINE COMMENTS

> emojier.cpp:65
> +                            "Need to create the dictionaries again.";
> +                return;
> +            }

leak of list?

> emojier.cpp:80
> +    QVariant data(const QModelIndex & index, int role) const override {
> +        if (index.parent().isValid() || index.column() != 0)
> +            return {};

there's a method in QAIM now called checkIndex() which can handle all this for you magically.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24454

To: apol, #plasma
Cc: davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191007/1e196c03/attachment.html>