D24379: [energy kcm] Fix Technology values

Méven Car noreply at phabricator.kde.org
Thu Oct 3 17:31:36 BST 2019


meven added a comment.


  In D24379#541409 <https://phabricator.kde.org/D24379#541409>, @davidedmundson wrote:
  
  > This is already available and translated in solid.
  >
  > solid/src/solid/devices/backends/upower/upowerdevice.cpp
  >  142:        return tr("Lithium Ion", "battery technology");
  
  
  Being a private function , this is quite complicated to expose and in solid's backend. k
  
  > Can't we expose that instead of duplicating things in QML. Especially with horrific magic numbers instead of enums.
  
  I have updated the code to use the enum properly.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D24379

To: meven, ngraham, ltoscano
Cc: davidedmundson, alexde, plasma-devel, ltoscano, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191003/85e32ed1/attachment-0001.html>


More information about the Plasma-devel mailing list