D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

Roman Gilg noreply at phabricator.kde.org
Wed Oct 2 15:36:59 BST 2019


romangg requested changes to this revision.
romangg added a comment.
This revision now requires changes to proceed.


  Last issue: we need to change in `kded/output.cpp` line 363 where it rounds on config write to one digit to round to two digits instead:
  
  `info[QStringLiteral("scale")] = int(output->scale() * 100 + 0.5) / 100.;`

INLINE COMMENTS

> OutputPanel.qml:90
> +                validator: DoubleValidator {
> +                    bottom: Math.min(spinbox.from, spinbox.to)*spinbox.factor
> +                    top:  Math.max(spinbox.from, spinbox.to)*spinbox.factor

whitespace around multiplication, next line as well

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191002/0f3ebf14/attachment.html>


More information about the Plasma-devel mailing list