D24359: Fix a number of issues found by the OpenSuse security team in networkhelper

[Arjen Hiemstra]

ahiemstra added a comment.


  Note that https://bugzilla.opensuse.org/show_bug.cgi?id=1152638 says `pcap_breakloop()` is unsupported when called from multiple threads. However, the actual libpcap documentation states:
  
  > Note also that, in a multi-threaded application, if one thread is blocked in pcap_dispatch(), pcap_loop(), pcap_next(3PCAP), or pcap_next_ex(3PCAP), a call to pcap_breakloop() in a different thread will not unblock that thread.
  
  Which is a bit different, as it implies (to me) that the loop will still exit the next time the thread is woken up from its blocking call. Which is fine, the thread will be woken up when the next packet arrives and then exit.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D24359

To: ahiemstra, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191002/8c3646f4/attachment.html>