D24305: [Cuttlefish] Compare an icon in different themes

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> Comparison.qml:66
> +                Item {
> +                    id: wrapper
> +                    Layout.preferredWidth: 128

I use it for centering the icon in the middle of the 128x128 free space for the icon. `Qt.AlignCenter` is not enough for that. In the first version of the diff I tried make up for that with setting of top and bottom margins depending on the text height and icon size but that was to complicated and also didn't produce the correct result I think.

REPOSITORY
  R118 Plasma SDK

BRANCH
  comparison (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24305

To: davidre, #plasma, #vdg, ngraham
Cc: ngraham, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191001/49b81748/attachment.html>